Fix undefined behavior in p4parser.ypp #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
approved these changes
May 25, 2017
mihaibudiu
reviewed
May 25, 2017
|
I like most languages better than C++. =) In fairness, in this particular case the root cause is a bug in Bison's variant implementation. They should've just used boost's version instead of reinventing the wheel. |
|
I'm hearing two votes for rewriting the compiler in OCaml?
…On Wed, May 24, 2017 at 8:03 PM Seth Fowler ***@***.***> wrote:
I like most languages better than C++. =)
In fairness, in this particular case the root cause is a bug in Bison's
variant implementation. They should've just used boost's version instead of
reinventing the wheel.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#664 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABwi0tEv6CqdOQ65rjUTcY_RCvREWhO6ks5r9O94gaJpZM4Nl4pC>
.
|
|
We can do F# if @mbudiu-vmw prefers...
…On Wed, May 24, 2017 at 8:22 PM Nate Foster ***@***.***> wrote:
I'm hearing two votes for rewriting the compiler in OCaml?
On Wed, May 24, 2017 at 8:03 PM Seth Fowler ***@***.***>
wrote:
> I like most languages better than C++. =)
>
> In fairness, in this particular case the root cause is a bug in Bison's
> variant implementation. They should've just used boost's version instead of
> reinventing the wheel.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#664 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ABwi0tEv6CqdOQ65rjUTcY_RCvREWhO6ks5r9O94gaJpZM4Nl4pC>
> .
>
|
|
+1 for OCaml |
|
Just imagine how much easier our lives would be if p4c was implemented in LabVIEW. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a (harmless) instance of undefined behavior in
p4parser.ypp. See the comment in the patch for more details.