[WIP - DO NOT MERGE] Add native preprocessor #68
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ChrisDodd @mbudiu-vmw
This is the prototype implementation for the native preprocessor proposal I posted here: p4lang/p4-spec#30
All existing unit tests pass except those that depend on the exact output of error messages, which show minor visual differences between the C preprocessor and this one. For example, the C preprocessor doesn't preserve whitespace between tokens (this one does) and it also removes comments (this one doesn't).
This PR doesn't include changes to the test data (#include -> #import, among other things) because that would clutter it too much.
The preprocessor ended up being decently small. Hopefully it gives a good idea of the effort required to implement the proposal.