Fix circular dep in includes #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@teverman FYI |
teverman
reviewed
May 31, 2017
antoninbas
force-pushed
the
fix-non-unified-build
branch
from
4f756ba
to
568eebd
Compare
|
@teverman I updated my commit to add a fwd declaration for Backend and move the constructor to the cpp file. What I'm worried about is that I don't seem to be catching these errors when I run my "non-unified" build |
|
Not sure why you wouldn't... |
teverman
approved these changes
May 31, 2017
|
can I get an approve for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.