Make side-effect order explicit #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDodd
reviewed
Sep 22, 2016
| } | ||
| if (left->is<IR::Type_Table>()) { | ||
| auto la = left->to<IR::Type_Table>(); | ||
| auto ra = right->to<IR::Type_Table>(); | ||
| return equivalent(la->getApplyMethodType(), ra->getApplyMethodType()); |
There was a problem hiding this comment.
Why change this code? The new code is identical in effect to the old code, just more verbose and harder to read.
| if (lm->returnType == nullptr) { | ||
| if (rm->returnType != nullptr) | ||
| return false; | ||
| } else if (rm->returnType == nullptr) { | ||
| return false; |
There was a problem hiding this comment.
@have equivalent check for nullptr args as the first thing it does, and you could eliminate all these (and other) nullptr checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other features in this pull request: