-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide sample protoc invocation for building protos #5
Comments
I think this is kind of covered by #11 |
chrispsommers
added a commit
that referenced
this issue
Feb 22, 2024
* Initial changes for generic tables * second changes * 3rd changes * 4th changes * 5th changes * Adding p4types and p4info changes for GenericData (#4) Adding another enum alongside P4IDs for generic tables as well * Adding varbits and a readme writeup (#5) * Adding varbit and a writeup * Adding proto changes * Adding genericTable for direct resources. Adding P4datatypespec to genericdatatype in p4types * * Adding more container types ** list ** bag ** set ** ordered_set * Moving GenericTable spec update to one big section to keep it organized * * Add Table categories introduction * * Adding 3-level property details (Table, Entry, field) * Adding more text on the data types in the spec * Adding Details on Operations in the Table categories * * Adding Read RPC details in table categories * Adding a table to show valid combinations of table properties * Adding default entry rules * Expanding combinations * review comments * * Explain more on indexed tables. How are duplicates handled * Add regular tables in the truth table * Calculation table can be volatile * Add column to lay out some examples for the table categories * Mention that the entry properties do not go in p4info * Flow chart to show INSERT decision flow. Added PNG file * Add in float more verbiage regarding volatile * Renamed generic_set to generic_unordered_set * Removed bag and ordered_set * Add p4type for string with min/max size * Update Go dependencies (#438) * Fixes #439 (#440) Change CI workflow to skip publishing if PR spawned by dependabot * * Adding categories and properties in p4info * Adding example changes for above in GenericTables.md * Add default values to p4info. * * Removed GenericTable category from the p4info * Added more text about generic table type * Corrected typos and reference links * Replaced png file with svg file * Removed is_const_table since table properties are present * Adding space for dummy commit * Correcting typo * Adding dev branches to workflows (#443) * Correcting linter errors * Generating go and py files * Adding text regarding direct resources as GenericTables in TableEntry * some review comment changes * Andy review comments * remove whitespace * * Correcting GenericTable.md according to the p4info * Removing repeated file dfrom Param and Match top level * * Removing float from p4info and spec * Adding default value text to spec * Adding UnorderedSet to runtime * * Adding section to P4DataTypeSpec to indicate adding to GenericDataTypeSpec for any new additions * Removing P4DataTypeSpec from GenericDataTypeSpec * Adding default value to bool in GenericData * Moving GenericTable.md to docs * Correcting spec for removal of p4_type in generic_type. Adding generated code * * Shortening the field names in `GenericTable` to remove "genric_table_" prefixes * Correcting the text for type_name * * Making default_value as bytes * Adding "scope" to the union example * Adding default string value * review comments * linter error * Review comments Signed-off-by: Sayan Bandyopadhyay <sayan.bandyopadhyay@intel.com> * Correcting whitespace errors Signed-off-by: Sayan Bandyopadhyay <sayan.bandyopadhyay@intel.com> * Updating generated code Signed-off-by: Sayan Bandyopadhyay <sayan.bandyopadhyay@intel.com> --------- Signed-off-by: Sayan Bandyopadhyay <sayan.bandyopadhyay@intel.com> Signed-off-by: Bandyopadhyay, Sayan <sayan.bandyopadhyay@intel.com> Co-authored-by: Antonin Bas <antonin.bas@gmail.com> Co-authored-by: Chris Sommers <31145757+chrispsommers@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be useful for someone adapting or integrating the protos into a new build system to have an example of how to set up the proto_path and invoke protoc correctly.
The text was updated successfully, but these errors were encountered: