Clarify section on Packet I/O messages #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular with regards to translated types.
| `ControllerPacketMetadata.Metadata` message with the same `id`, in the | ||
| following sense: | ||
| + If `ControllerPacketMetadata.Metadata.bitwidth` is set, or if | ||
| `ControllerPacketMetadata.Metadata.type_name` is set and |
There was a problem hiding this comment.
As a related point, It seems like the P4RT spec doesn't have any examples of a ControllerPacketMetadata with type_name being utilized. Do you think it'd be valuable to add such an example and show corresponding P4NewTypeSpec?
| for the type name, then `PacketMetadata.value` must be a binary string of | ||
| the specified bit width conforming to the [Bytestrings](#sec-bytestrings) | ||
| requirements. | ||
| + If `ControllerPacketMetadata.Metadata.type_name` is set and |
There was a problem hiding this comment.
Again, a worked-out example might help here.
chrispsommers
approved these changes
May 9, 2023
|
I agree that adding examples would be useful. |
|
Sure, that's why I approved, you can put this idea in backlog. Feel free to merge. |
|
Sounds good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular with regards to translated types.