Fixes space for p4lang/p4rt-asciidoc #536
Conversation
Signed-off-by: Dscano <d.scano89@gmail.com>
Signed-off-by: Dscano <d.scano89@gmail.com>
| @@ -13,7 +13,7 @@ jobs: | |||
| - uses: actions/checkout@v3 | |||
| - name: Build spec | |||
| run: | | |||
| docker run -v `pwd`/docs/v1:/usr/src/p4-spec p4lang/p4rt-asciidoc :latest make | |||
| docker run -v `pwd`/docs/v1:/usr/src/p4-spec p4lang/p4rt-asciidoc:latest make | |||
There was a problem hiding this comment.
@Dscano I believe you need to build the dockerfile before you docker run ... in all the CI scripts, or it'll fail to find the image. This is similar to what you had to do in the original MR:
p4runtime/.github/workflows/spec.yml
Line 28 in 7e981d8
It's a consequence of not having a public docker image. Unfortunately, this is not exposed until CI runs after the merge occurs. Can you make sure this is added to all the CI files accordingly? Thanks.
|
@Dscano still failing, can you please take a look? Thanks. https://github.com/p4lang/p4runtime/actions/runs/12957404006/job/36145683090#step:4:3967 |
I addressed it here #538 |
No description provided.