Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deparser header struct to direction inout #127

Conversation

jafingerhut
Copy link
Collaborator

No description provided.

Copy link

@shirshyad shirshyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mariobaldi mariobaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are as discussed during one of the Architecture Workgroup meetings

@jafingerhut
Copy link
Collaborator Author

Two positive reviews, so merging this.

@jafingerhut jafingerhut merged commit 484af95 into p4lang:main Feb 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants