Ops #33
Open
Ops #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- group reason codes to use reason-code bit mask - add reason_code mask in the filter key - simplify filter compare code
|
it looks good. |
| @@ -446,12 +446,13 @@ switch_api_init_default_acl_entries(switch_device_t device) | |||
| acl_kvp[1].mask.u.mask = 0xFFFFFFFF; | |||
| memset(&action_params, 0, sizeof(switch_acl_action_params_t)); | |||
| action_params.cpu_redirect.reason_code = 0; | |||
| switch_api_acl_rule_create(device, acl_handle, priority++, 2, | |||
| switch_api_acl_rule_create(device, acl_handle, | |||
| 2000, /* keep priority lower than reason-codes */ | |||
There was a problem hiding this comment.
Maybe we should have a predefined reason code for this in switch_hostif.c as well.
- Fixes filter delete code
- Cleanup based on earlier comments, create filter match routines that can be
shared between delete and lookup
- Add L3_REDIRECT reason code to identify packets sent to cpu using
fib_redirect action
This allows switchapi logs to be integrated with customer's logging infra
Add apis to register external logger function.
* qos, nat and copp support from p4lang * remove sflow header for cpu rx bound packets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only for review.. do not merge