Added ModifyTableEntry method for modifying table entries in P4Runtime #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…table entries with optional dry run mode
Abhinavcode13
changed the title
jafingerhut
reviewed
Apr 19, 2024
| print("P4Runtime Modify: ", request) | ||
| else: | ||
| self.client_stub.Write(request) | ||
|
|
There was a problem hiding this comment.
Have you tested it?
It would be good to test not only for modifying a normal entry of a table, but also test it to see if it works when modifying a default action of a table.
There was a problem hiding this comment.
Could you please provide an approach on how to effectively test the ModifyTableEntry method to ensure it handles modifications of both normal entries and default actions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jafingerhut , PTAL.