Skip to content

Commit

Permalink
fix: Rescheduling email when there is broken calendar integration (ca…
Browse files Browse the repository at this point in the history
  • Loading branch information
hariombalhara authored and p6l-richard committed Jul 22, 2024
1 parent 874c3fc commit 6baf1dc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
3 changes: 1 addition & 2 deletions packages/features/bookings/lib/handleNewBooking.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1268,8 +1268,7 @@ async function handler(

evt.appsStatus = handleAppsStatus(results, booking, reqAppsStatus);

// If there is an integration error, we don't send successful rescheduling email, instead broken integration email should be sent that are handled by either CalendarManager or videoClient
if (noEmail !== true && isConfirmedByDefault && !isThereAnIntegrationError) {
if (noEmail !== true && isConfirmedByDefault) {
const copyEvent = cloneDeep(evt);
const copyEventAdditionalInfo = {
...copyEvent,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -660,8 +660,11 @@ describe("handleNewBooking", () => {

expectWorkflowToBeTriggered({ emailsToReceive: [organizer.email], emails });

// FIXME: We should send Broken Integration emails on calendar event updation failure
// expectBrokenIntegrationEmails({ booker, organizer, emails });
expectSuccessfulBookingRescheduledEmails({
booker,
organizer,
emails,
});

expectBookingRescheduledWebhookToHaveBeenFired({
booker,
Expand Down

0 comments on commit 6baf1dc

Please sign in to comment.