Automatically produce all binaries for releases from GitHub Actions #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction to publish binary artifacts
…list files in `bin` folders
jinfeihan57
reviewed
Dec 5, 2020
| - name: Upload the cmake Linux binary artifacts | ||
| uses: svenstaro/upload-release-action@v2 | ||
| with: | ||
| repo_token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Can you explain the work flow here? I'm not very good at git action.
Should I set a secrets.GITHUB_TOKEN ?
Thanks!
There was a problem hiding this comment.
No, that is provided, pulled in by GitHub Actions. The action and binaries for release are only produced when you go and actually create an release tag.
As i have here: https://github.com/techno-express/p7zip/releases
This is from https://github.com/marketplace/actions/upload-files-to-a-github-release
|
Thanks! ; ) |
GerHobbelt
pushed a commit
to GerHobbelt/p7zip
that referenced
this pull request
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to https://github.com/jinfeihan57/p7zip/issues/105.
Having a Apple Mac is not necessary, the binaries are already being produced and tested on macOS platform. It seems the project here was uploading the binaries, when there is really no need for that, plus this is more secure.