-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7zip 21.07 #171
7zip 21.07 #171
Conversation
https://github.com/jinfeihan57/p7zip/issues/156#issuecomment-891433297 |
@teoberi I think the next goal is https://github.com/jinfeihan57/p7zip/issues/141 |
Good work! Compiles fine with the following changes.
|
#172 supports uasm (I did need to prepare https://github.com/cielavenir/homebrew-ciel/blob/master/uasm.rb beforehand though) |
You can try remove leading white spaces and then compare; like this:
|
@cielavenir Thank you very much for your work, but there is so much code to review that my computer can't display them all. So I did the update of p7zip21.07 myself. Please follow this branch. If you have any ideas you can submit the code on the new branch. I will close this merge request. |
closes #156
what I did was basically overwriting 21.07 onto 6c6ed1e and merged it to 7zip_21.02 HEAD.
However I have to say one thing: on c65ff52 you ran some code formatter on CPP/7zip/Archive/7z/7zHandler.cpp right? it broke almost everything and I had to check conflict carefully.
Next time please keep the changes very least including indentation.
also please name 672af56 "mirror" (or "7zip_mirror" or "upstream") on your repository for our ease afterwards.
/cc @pashamcr @teoberi