Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry launching browser once if it fails the first time #138

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Conversation

josebolos
Copy link
Member

@josebolos josebolos commented May 24, 2021

This is a first attempt at fixing #128. It's unlikely to fix the issue completely, or even at all, as the browser will sometimes crash after testing several URLs and we don't have any logic to reopen a browser that has crashed mid-testing.

This is a first attempt at fixing #128. It's unlikely to fix the issue completely, or even at all, as the browser will sometimes crash after testing several URLs and we don't have any logic to reopen a browser that has crashed mid-tests.
@josebolos josebolos changed the title Retry launching browser if first time fails Retry launching browser once if first time fails Jun 28, 2021
@josebolos josebolos changed the title Retry launching browser once if first time fails Retry launching browser once if it fails the first time Jun 28, 2021
Copy link
Member

@sangitamane sangitamane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@josebolos josebolos merged commit fefa70b into master Jun 28, 2021
@josebolos josebolos deleted the issue-128 branch June 28, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants