Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js support to 18-20 from 12-16, dependencies, documentation, some practices #19

Merged
merged 31 commits into from
Oct 11, 2023
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
e5cb4dd
Update name of repo for repository, homepage, bugs
danyalaytekin Oct 4, 2023
b35be14
Remove unused Grunt task 'ci'
danyalaytekin Oct 4, 2023
5947cfc
Update sinon to 16 from 1.7, to fix circular dependency warnings invo…
danyalaytekin Oct 4, 2023
9d92fbe
Use github: syntax for package.repository
danyalaytekin Oct 4, 2023
760fc62
Update copyright range end to 2023 from 2019
danyalaytekin Oct 4, 2023
d84be46
Update year in examples to 2023 from 2013
danyalaytekin Oct 4, 2023
2f0e95c
Remove $ from example code blocks of type shell
danyalaytekin Oct 4, 2023
d00cdff
Use const instead of var
danyalaytekin Oct 4, 2023
70f9e08
Upgrade native actions (checkout, setup-node); remove repetition pres…
danyalaytekin Oct 4, 2023
edb1aa0
Run on pull_request regardless of target branch
danyalaytekin Oct 4, 2023
0e4186c
Run on push to main as well as master, pending rename
danyalaytekin Oct 4, 2023
32b7a1e
Fix Node.js version format (use N not N.x); also use array syntax
danyalaytekin Oct 5, 2023
6e1a8b3
Add Node.js 18, 20; drop 12
danyalaytekin Oct 5, 2023
56eb6e0
Replace deprecated 'es3: false' with 'esversion: 6'
danyalaytekin Oct 5, 2023
5433995
Set minimum package.engines.node to 14
danyalaytekin Oct 5, 2023
f026437
Upgrade Grunt and plugins to latest
danyalaytekin Oct 5, 2023
7ec88c3
Upgrade mockery to 2.1 from 1.4 (soft major)
danyalaytekin Oct 5, 2023
ec5d45c
Update Mocha to 10.2 from 8.4
danyalaytekin Oct 5, 2023
deffcb1
Use const instead of var for some constants
danyalaytekin Oct 5, 2023
85c7323
Retire recommendation for grunt-cli installed globally
danyalaytekin Oct 5, 2023
bf55836
Make small changes to readme for clarity
danyalaytekin Oct 5, 2023
a3e5c44
Separate tool usage code blocks to allow them to be copied individually
danyalaytekin Oct 5, 2023
e774ac6
Clarify inferred support policy
danyalaytekin Oct 5, 2023
7558950
Recommend npm >=8 and update lockfile using this version (also upgrad…
danyalaytekin Oct 5, 2023
c16a654
Prepare version 4's details for README and MIGRATION; sunset <= 3
danyalaytekin Oct 5, 2023
c17bfa5
Remove support symbols since their validity is affected by the passag…
danyalaytekin Oct 5, 2023
9c4d1c5
Fix build badge and info link
danyalaytekin Oct 5, 2023
7fc14d8
Rename job 'checkout_and_test' to 'test'
danyalaytekin Oct 5, 2023
e84b8bb
Recommend npm version 8 or above, or equivalent, in migration guide f…
danyalaytekin Oct 5, 2023
84c7ec9
End support for post-LTS Node.js versions 14 and 16
danyalaytekin Oct 6, 2023
78836b1
Reverse change to support policy section pending discussion
danyalaytekin Oct 6, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update year in examples to 2023 from 2013
danyalaytekin committed Oct 4, 2023
commit d84be460fd7496ac3befe51da439310029569008
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -53,8 +53,8 @@ client.tasks.results({}, function (err, results) {

// Get results for all tasks within a date range
client.tasks.results({
from: '2013-01-01',
to: '2013-01-31'
from: '2023-01-01',
to: '2023-01-31'
}, function (err, results) {
// results = array of objects representing results, or null if an error occurred
});
@@ -102,8 +102,8 @@ client.task('5231c687bbdf0f94fa000007').results({}, function (err, results) {

// Get results for a task within a date range
client.task('5231c687bbdf0f94fa000007').results({
from: '2013-01-01',
to: '2013-01-31'
from: '2023-01-01',
to: '2023-01-31'
}, function (err, results) {
// results = array of objects representing results, or null if an error occurred
});