Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pa11y@8 #161

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Upgrade to pa11y@8 #161

merged 3 commits into from
Apr 10, 2024

Conversation

danyalaytekin
Copy link
Member

@danyalaytekin danyalaytekin commented Apr 8, 2024

Changes

  • Upgrade to pa11y@^8 from ^7
  • Fix name of publishing job
  • Use ubuntu-latest in publish

Would become part of v5.


I'd hoped to smuggle in an upgrade to eslint@9 here, to fix an npm audit warning, but it turned out a bigger job than I'd thought. I'll wait for our linting configuration to become an ESLint Shareable Config first:

This way we won't have to use the flat config converter in addition to any other changes (untested assumption).

@danyalaytekin danyalaytekin added the status: work required Work in progress label Apr 8, 2024
@danyalaytekin danyalaytekin added this to the 5.0.0 milestone Apr 8, 2024
@danyalaytekin danyalaytekin added type: maintenance dependencies Pull requests that update a dependency file and removed status: work required Work in progress labels Apr 8, 2024
@danyalaytekin danyalaytekin changed the title [WIP, draft] Upgrade to pa11y@8, and upgrade two dev deps to fix npm audit alert Upgrade to pa11y@8 Apr 8, 2024
@danyalaytekin danyalaytekin marked this pull request as ready for review April 8, 2024 22:35
Copy link
Member

@hollsk hollsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡ 👍

@danyalaytekin danyalaytekin merged commit 2af525e into main Apr 10, 2024
10 checks passed
@danyalaytekin danyalaytekin deleted the use-pa11y-8 branch April 10, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file type: maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants