Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to recognise "lcov" format due to a earlier failure #159

Closed
hitmands opened this issue Apr 21, 2020 · 6 comments
Closed

unable to recognise "lcov" format due to a earlier failure #159

hitmands opened this issue Apr 21, 2020 · 6 comments
Assignees
Labels
need-more-info Need additional information to debug/reproduce

Comments

@hitmands
Copy link

Describe the bug
The upload fails without causing the job to fail

Example links
image

image

Expected behavior
The coverage report should be recognised as "lcov" and correctly uploaded

Additional context
Add any other context about the problem here.
image

@hitmands hitmands added the bug Something isn't working label Apr 21, 2020
@paambaati
Copy link
Owner

@hitmands Can you try v2.6.0? Also please follow the issue template and include links, not screenshots.

@paambaati paambaati added need-more-info Need additional information to debug/reproduce and removed bug Something isn't working labels Apr 24, 2020
@wagenet
Copy link

wagenet commented May 6, 2020

I'm seeing something similar with 2.6.0:

2020-05-06T22:52:09.8261414Z [command]/__w/skylight-rust/skylight-rust/cc-reporter format-coverage /__w/skylight-rust/skylight-rust/coverage/lcov.info -t lcov -o codeclimate.0.json
2020-05-06T22:52:09.8338360Z fatal: Not a git repository (or any parent up to mount point /__w)
2020-05-06T22:52:09.8339052Z Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
2020-05-06T22:52:09.8342532Z Error: exit status 128
2020-05-06T22:52:09.8352365Z Usage:
2020-05-06T22:52:09.8352933Z   cc-test-reporter format-coverage [coverage file] [flags]
2020-05-06T22:52:09.8353035Z 
2020-05-06T22:52:09.8353169Z Flags:
2020-05-06T22:52:09.8353469Z       --add-prefix string   add this prefix to file paths
2020-05-06T22:52:09.8353874Z   -t, --input-type string   type of input source to use [clover, cobertura, coverage.py, excoveralls, gcov, gocov, jacoco, lcov, simplecov, xccov]
2020-05-06T22:52:09.8354218Z   -o, --output string       output path (default "coverage/codeclimate.json")
2020-05-06T22:52:09.8354631Z   -p, --prefix string       the root directory where the coverage analysis was performed (default "/__w/skylight-rust/skylight-rust")
2020-05-06T22:52:09.8354743Z 
2020-05-06T22:52:09.8354875Z Global Flags:
2020-05-06T22:52:09.8355144Z   -d, --debug   run in debug mode
2020-05-06T22:52:09.8355229Z 
2020-05-06T22:52:09.8379983Z (node:823) UnhandledPromiseRejectionWarning: TypeError: (s || "").replace is not a function
2020-05-06T22:52:09.8380659Z     at escapeData (/__w/_actions/paambaati/codeclimate-action/v2.6.0/node_modules/@actions/core/lib/command.js:66:10)

@CeeDeeBee
Copy link

CeeDeeBee commented May 13, 2020

Still having this issue in 2.6.0. Getting the same error as posted above by @wagenet. I believe this is due to a bug with the @actions/core dependency. May be able to fix by merging #172. @actions/core release 1.2.4 resolved issue #398 as seen here.

@wagenet
Copy link

wagenet commented May 14, 2020

In my case, I believe cc-test-reporter was failing because I didn't actually have a git repo present. (This was because I didn't have an up-to-date version of git in my container so the checkout action was actually just doing a directory copy.) I don't think this action can fix that situation, but it could handle it more gracefully, maybe even giving a warning about this scenario to the end user.

@CeeDeeBee
Copy link

Ahh yeah, you're right. The @actions/core issue was not the actual cause of my issue. My error was due to integration with cypress which I was able to resolve by calling cypress-io/github-action before the codeclimate-action.

@paambaati
Copy link
Owner

Closing this, as this seems to be resolved. If you're still seeing this in the latest v2.7.0 release, please feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-more-info Need additional information to debug/reproduce
Projects
None yet
Development

No branches or pull requests

4 participants