Be more lenient in accepting command inputs #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thboop
commented
Apr 6, 2020
hross
approved these changes
Apr 7, 2020
|
interested in @ericsciple feedback |
ericsciple
reviewed
Apr 8, 2020
ericsciple
reviewed
Apr 8, 2020
ericsciple
reviewed
Apr 8, 2020
ericsciple
reviewed
Apr 8, 2020
ericsciple
reviewed
Apr 8, 2020
ericsciple
reviewed
Apr 8, 2020
ericsciple
reviewed
Apr 8, 2020
ericsciple
reviewed
Apr 8, 2020
thboop
force-pushed
the
thboop/AddErrorInputToSetFailed
branch
from
508796f
to
3ab3ad1
Compare
ericsciple
reviewed
Apr 9, 2020
ericsciple
approved these changes
Apr 9, 2020
This was referenced Apr 13, 2020
|
Late to the party here ( 🎉 for resolving!!)... but shouldn't the |
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users have been encountering friction when trying to use command inputs.
This commit broke some our handling when users don't pass in strings. We re-added that handling and implemented a test for it.
We also have had a number of users ask for additional input types.
#386 -> Set Failed and Error should accept errors
#370 -> Set Output should format data into strings
This commit resolves those use cases.
Resolves #398, #386, #370