Upgrade to svelte 4 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this includes replacing eslint-plugin-svelte3 with eslint-plugin-svelte which is recommend
@pablo-abc this simplifies testing with almost zero config and eliminates the hair pulling that comes with esm/cjs environments
|
@pablo-abc, the PR is now ready for review |
|
Actually appreciate moving to Vitest! I've wanted to do it for a while. Thanks for the pull request! |
|
It's failing to run! If you can update the workflow files to include node 16.x and 18.x instead of 12 and 14, I think that'd fix it |
|
Done in b6d1abe |
paolodina
added a commit
to paolodina/svelte-markdown
that referenced
this pull request
Jul 26, 2023
pablo-abc
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cc @pablo-abc