Allow configuration of request options #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablo-co
commented
May 23, 2017
| config = Map.put(@config, :request_options, request_options) | ||
|
|
||
| assert_raise Bamboo.PostmarkAdapter.ApiError, fn -> | ||
| new_email() |> PostmarkAdapter.deliver(config) |
There was a problem hiding this comment.
Use a function call when a pipeline is only one function long
In some cases it might be useful being able to specify the options that are sent to hackney such as the request timeout. This change introduces support for such cases through the configuration hash.
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/pablo-co/bamboo_postmark/pulls/12. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases it might be useful being able to specify the options that
are sent to hackney such as the request timeout. This change introduces
support for such cases through the configuration hash.