Fix Elixir 1.4 warnings and deprecations #7
Conversation
|
Hello, @whodidthis! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
| @@ -158,7 +158,7 @@ defmodule Bamboo.PostmarkAdapterTest do | |||
| end | |||
|
|
|||
| test "deliver/2 puts tag param" do | |||
| email = new_email |> PostmarkHelper.tag("some_tag") | |||
| email = new_email() |> PostmarkHelper.tag("some_tag") | |||
There was a problem hiding this comment.
Use a function call when a pipeline is only one function long
| @@ -144,7 +144,7 @@ defmodule Bamboo.PostmarkAdapterTest do | |||
| end | |||
|
|
|||
| test "deliver/2 puts template name and content" do | |||
| email = new_email |> PostmarkHelper.template("hello", [ | |||
| email = new_email() |> PostmarkHelper.template("hello", [ | |||
There was a problem hiding this comment.
Use a function call when a pipeline is only one function long
| @@ -133,7 +133,7 @@ defmodule Bamboo.PostmarkAdapterTest do | |||
| end | |||
|
|
|||
| test "deliver/2 puts template name and empty content" do | |||
| email = new_email |> PostmarkHelper.template("hello") | |||
| email = new_email() |> PostmarkHelper.template("hello") | |||
There was a problem hiding this comment.
Use a function call when a pipeline is only one function long
| @@ -82,15 +82,15 @@ defmodule Bamboo.PostmarkAdapterTest do | |||
| end | |||
|
|
|||
| test "deliver/2 sends the to the right url" do | |||
| new_email |> PostmarkAdapter.deliver(@config) | |||
| new_email() |> PostmarkAdapter.deliver(@config) | |||
There was a problem hiding this comment.
Use a function call when a pipeline is only one function long
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/pablo-co/bamboo_postmark/pulls/7. |
|
Thanks @whodidthis, it looks great. I'll merge it in. |
No description provided.