Add Postmark email opens and links tracking options #8
Conversation
| test "deliver/2 puts tracking params" do | ||
| email = new_email() |> PostmarkHelper.tracking(%{opens: true, links: "HtmlOnly"}) | ||
|
|
||
| email |> PostmarkAdapter.deliver(@config) |
There was a problem hiding this comment.
Use a function call when a pipeline is only one function long
| @@ -165,6 +165,14 @@ defmodule Bamboo.PostmarkAdapterTest do | |||
| assert_receive {:fake_postmark, %{params: %{"Tag" => "some_tag"}}} | |||
| end | |||
|
|
|||
| test "deliver/2 puts tracking params" do | |||
| email = new_email() |> PostmarkHelper.tracking(%{opens: true, links: "HtmlOnly"}) | |||
There was a problem hiding this comment.
Use a function call when a pipeline is only one function long
lib/bamboo/postmark_adapter.ex
Outdated
| @@ -103,6 +104,17 @@ defmodule Bamboo.PostmarkAdapter do | |||
| params | |||
| end | |||
|
|
|||
| defp maybe_put_tracking_params(params, %{private: | |||
There was a problem hiding this comment.
There should be no trailing white-space at the end of a line.
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/pablo-co/bamboo_postmark/pulls/8. |
|
Thanks for your work! To better reflect the act of tracking I would rename the For the link tracking I think it would be cleaner to declare them through symbols: |
|
Actually now that I look at the official adapters it looks like we should just provide a I can redo this pr more in line with the official ones if you want? |
|
Sorry, the last 2 weeks have been really busy. It actually sounds like a great idea to use a |
|
Closed in favor of #9. |
Hopefully the api is fine.
Do you think the adapter should throw if TrackLinks option is not one of the possible values "None", "HtmlOnly", "TextOnly" or "HtmlAndText"?
http://developer.postmarkapp.com/developer-api-email.html