Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental Quantica.gap(h::Hamiltonian, µ = 0) convenience function for 1D Hamiltonians #294

Merged
merged 9 commits into from
Jun 26, 2024

Conversation

pablosanjose
Copy link
Owner

@pablosanjose pablosanjose commented Jun 5, 2024

It's a common pattern to need the gap in some bands. This adds an efficient method to do that for the 1D case, by using the Schur solver to locate the likely locations of the gaps in the Brillouin zone. Not exported for the moment, but documented.

The closely related Quantica.decay_lengths function is also documented here, but is also unexported.

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.54%. Comparing base (b12ba01) to head (e4e90d8).

Files Patch % Lines
src/solvers/green/bands.jl 88.88% 1 Missing ⚠️
src/solvers/green/schur.jl 75.00% 1 Missing ⚠️
src/tools.jl 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
- Coverage   92.55%   92.54%   -0.02%     
==========================================
  Files          37       37              
  Lines        6270     6287      +17     
==========================================
+ Hits         5803     5818      +15     
- Misses        467      469       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pablosanjose pablosanjose changed the title Add unexported Quantica.gap(h::Hamiltonian, µ = 0) convenience function for 1D Hamiltonians Add experimental Quantica.gap(h::Hamiltonian, µ = 0) convenience function for 1D Hamiltonians Jun 21, 2024
@pablosanjose pablosanjose marked this pull request as ready for review June 21, 2024 14:46
docs correction

docstring fix
@pablosanjose
Copy link
Owner Author

Failures on nightly are unrelated (CairoMakie issue)

@pablosanjose pablosanjose merged commit 5c6d85a into master Jun 26, 2024
6 of 9 checks passed
@pablosanjose pablosanjose deleted the gap branch June 28, 2024 14:11
@pablosanjose pablosanjose mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants