-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EigenSolvers as extensions #298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FunctionWrappers world age error workaround fix fix
remove FFTW from extras
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #298 +/- ##
==========================================
- Coverage 92.61% 92.55% -0.07%
==========================================
Files 37 37
Lines 6299 6270 -29
==========================================
- Hits 5834 5803 -31
- Misses 465 467 +2 ☔ View full report in Codecov by Sentry. |
The test failures on nightly are unrelated, and caused by CairoMakie, so they are not blocking. |
another test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #297
We introduce extensions for LinearMaps, ArnoldiMethod, KrylovKit and Arpack.
This has revealed yet another issue with FunctionWrappers.jl, similar to #235, but not quite the same. When attempting to call
spectrum(h; solver = ...)
with an unloaded extension for the solver, it would error as expected. Then, after loading the relevant package, callingspectrum
again would yield a weird error such asThis likely stems from FunctionWrappers' issues with the world age system, and is, interestingly, fixed by the same approach as #235. However this impacts also aarch64 (macos) and Julia 1.11, unlike #235, so it seems to be more general.
We have implemented a cheaper fix, trying for the moment to avoid excising FunctionWrappers altogether (which, admittedly, improves compile and runtime performance in Quantica). It consists of always running the wrapped eigensolver with a
dryrun=true
option to make it almost free, but force it to compile.