Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: ensure correct dealiasing of lattices in attach #321

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

pablosanjose
Copy link
Owner

@pablosanjose pablosanjose commented Nov 20, 2024

Reverts #319

The fix in #319 was wrong. It made copy_lattice(ph::ParametricHamiltonian) copy the lattices of the parent and the embedded Hamiltonian, instead of only the parent one. In fact, the right fix is to copy only the embedded Hamiltonian because transform and translate modify lattice(ph) = lattice(hamiltonian(ph)) only, not lattice(parent(ph)), which must remain untouched. As a result the two lattices need not coincide in general.

@pablosanjose pablosanjose changed the title Bugfix: ensure full dealiasing of lattices in attach Bugfix: ensure correct dealiasing of lattices in attach Nov 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.47%. Comparing base (437e522) to head (3c39b75).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   92.47%   92.47%   -0.01%     
==========================================
  Files          39       39              
  Lines        6912     6906       -6     
==========================================
- Hits         6392     6386       -6     
  Misses        520      520              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@pablosanjose pablosanjose merged commit 75fd834 into master Nov 20, 2024
9 checks passed
@pablosanjose pablosanjose mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants