Bugfix: ensure correct dealiasing of lattices in attach #321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #319
The fix in #319 was wrong. It made
copy_lattice(ph::ParametricHamiltonian)
copy the lattices of the parent and the embeddedHamiltonian
, instead of only the parent one. In fact, the right fix is to copy only the embedded Hamiltonian becausetransform
andtranslate
modifylattice(ph) = lattice(hamiltonian(ph))
only, notlattice(parent(ph))
, which must remain untouched. As a result the two lattices need not coincide in general.