Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jersey 2.29+ breaks Pac4JValueFactoryProvider #73

Closed
gneuvill opened this issue Jan 23, 2020 · 3 comments
Closed

jersey 2.29+ breaks Pac4JValueFactoryProvider #73

gneuvill opened this issue Jan 23, 2020 · 3 comments

Comments

@gneuvill
Copy link
Contributor

See eclipse-ee4j/jersey#4091

Enum Parameter$Source has moved from org.glassfish.jersey.server.model to org.glassfish.jersey.model.Parameter
@leleuj
Copy link
Member

leleuj commented Jan 23, 2020

OK. What's your proposal on this? We already have a jersey225 module...

@victornoel
Copy link
Member

Just to chip in but I wouldn't be able to help, the solution would be to introduce another submodule for this jersey version yes.
It's not very hard to do, just copy the existing one and adapt it so that it works with jersey 2.29+, there should be tests and everything else already implemented.

@leleuj
Copy link
Member

leleuj commented Jan 24, 2020

@victornoel Thanks for the hint. Let's hope there won't be too many breaking changes in Jersey...

@gneuvill How do you feel about this solution? Can you submit a PR? Thanks

gneuvill pushed a commit to gneuvill/jax-rs-pac4j that referenced this issue Feb 26, 2020
Fix pac4j#73
8244518
@leleuj leleuj closed this as completed in 0510235 Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@victornoel @gneuvill @leleuj