-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a multimodule maven organisation #37
Conversation
@leleuj open question: should |
@victornoel I'm not sure about the "test-tools" name I initially suggested, what do you think about "testing-tools" or just "testing"? Other than that, it seems pretty good to me. The part I liked the less in my commits for #36 won't be needed, I'm happy about this. I'll try to integrate this in our own project tomorrow in order to see if anything breaks. I'll let you know. Thanks! |
About the groupId, I would stick to |
Ok, I will keep I will also rename the |
- Users should depend on jersey-pac4j or resteasy-pac4j - jax-rs-pac4j has been removed - Add saveInSession parameter for callback endpoints
I updated the PR, I will merge it later tonight except if you have other feedbacks :) |
Nothing to report here. |
This simplifies and re-enforce the correctness of the testing and will ease the support of jersey 2.26 and other implementations (see #36 #30).
@pierre-l if you have some feedback on that? I will then do the same for branch 2.x and add a legacy dependency
org.pac4j.jax-rs-pac4j
for backward compatibility.@leleuj once this is merged,
dropwizard-pac4j
will only depends onjersey-pac4j
.