-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make max_width
of help configurable
#340
Conversation
Draft, because I mean to add derive support and docs, but I'd like to gather a response to the general approach, before spending more time on it. |
I'm not opposed to making it configurable even though I'm curious about the motivation. Implementation looks about right. |
For once 100 characters might not be universally agreed upon (terminals commonly defaulting to 80, ssh reporting a term width of 80, etc). |
Let me know if you need any help with that change :) |
60bb98e
to
f4f67df
Compare
Alright, derive support is in as well now, and fixed the tests that broke due to including the next word width in the breaking decision. |
CI failure is not related to your changes. I guess I need to decide how much effort I'm willing to put into supporting rustc 1.56... Will try to fix it tomorrow-ish. |
f4f67df
to
e974fe6
Compare
bpaf
currently applies column wrapping at a hardcoded width of 100 characters.This PR aims to make this width configurable via the option parser.
Additionally it contributes a fix to the breaking logic where earlier only the current cursor position was used to determine, resulting in the trailing word overflowing the set width of 100.