Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for no_mangle in macOS #217

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

ansg191
Copy link
Contributor

@ansg191 ansg191 commented Nov 9, 2023

Currently, no_mangle functions are not being found on macOS because de-mangling fails & the .text sections are a different format on macOS.

This PR adds support for finding no_mangle attributes in macOS using the .globl directive & refactors asm::find_items a little to reduce nesting.

Related: #137

@ansg191 ansg191 requested a review from pacak November 9, 2023 16:32
@pacak pacak merged commit 29d0e50 into pacak:master Nov 9, 2023
3 checks passed
@pacak
Copy link
Owner

pacak commented Nov 9, 2023

Thank you for your contribution, I'll try to release a new version in a day or two.

@ansg191 ansg191 deleted the ansg191/macos-nomangle branch November 9, 2023 19:37
@pacak pacak mentioned this pull request Nov 10, 2023
@pacak
Copy link
Owner

pacak commented Nov 10, 2023

I released 0.2.22 (#218)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants