Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to choose tab-tap behaviour. #939

Closed
nikclayton opened this issue Sep 20, 2024 · 2 comments · Fixed by #955
Closed

Option to choose tab-tap behaviour. #939

nikclayton opened this issue Sep 20, 2024 · 2 comments · Fixed by #955
Assignees
@nikclayton

Comments

@nikclayton
Copy link
Contributor

nikclayton commented Sep 20, 2024 •
edited
Loading

Some people want tab-tap to act like "Load newest". This is dangerous behaviour to have as default (the user might be taken very far from their chosen position), but it seems reasonable to add as an option.

So a general preference, something like "Tab-tap behaviour" and two options:

(x) Jump up one page
( ) Jump to newest posts

See https://troet.cafe/@andreas_heitmann/113157476673289558
@nichu42
Copy link
Contributor

nichu42 commented Sep 20, 2024

Oh yes, please!

@nikclayton nikclayton self-assigned this Sep 27, 2024
nikclayton added a commit that referenced this issue Sep 27, 2024
@nikclayton
feat: Allow the user to chose behaviour when tapping a tab
5ca326a 
Previously, tapping a tab would jump to the top of the loaded content,
which might trigger a load of a fresh page.

Provide a preference to control this; the default is the current
behaviour, the user can also choose to discard the current content and
load the newest content.

Fixes #939
@nikclayton nikclayton mentioned this issue Sep 27, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Pachli roadmap Sep 27, 2024
@nichu42
Copy link
Contributor

nichu42 commented Oct 30, 2024

Just wanted to let you know that the lab feature works perfectly! I wouldn't want to miss it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikclayton nikclayton

Labels
None yet
Projects
Pachli roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow the user to chose behaviour when tapping a tab pachli/pachli-android
2 participants
@nikclayton @nichu42