Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve parsing of Friendica (and other server) version formats #376

Merged
merged 3 commits into from
Jan 23, 2024

Commits on Jan 23, 2024

  1. fix: Improve parsing of Friendica (and other server) version formats

    fix: Improve parsing of Friendica (and other server) version formats
    
    Previous code could return an error on Friendica version strings like
    `2024.03-dev-1547`.
    
    Fix this:
    
    - Extend the list of explicitly supported servers to include
      Fedibird, Friendica, Glitch, Hometown, Iceshrimp, Pixelfed, and
      Sharkey.
    
    - Add version parsing routines for these servers.
    
    - Test the version parsing routines fetching every server and
      version seen by Fediverse Observer (~ 2,000 servers) and ensuring
      that the server and version information can be parsed.
    
    Improve the error message:
    
    - Show the hostname with a `ServerRepository` error
    
    Clean up the code:
    
    - Remove the custom `resultOf` and `mapResult` functions, they have
      equivalents in newer versions of the library (like
      `runSuspendCatching`)
    
    Fixes pachli#372
    nikclayton committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    8dc6951 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7fe2cd1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bff1e13 View commit details
    Browse the repository at this point in the history