Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Show notification fetch errors instead of JSON #942

Merged
merged 2 commits into from
Sep 25, 2024
Merged

fix: Show notification fetch errors instead of JSON #942

merged 2 commits into from
Sep 25, 2024

Commits on Sep 25, 2024

  1. fix: Show notification fetch errors instead of JSON 

    Previous code showed any JSON-wrapped errors from notification fetches
as the JSON string, instead of the error message.

Fix this by switching to `ApiResult` and using the formatted error
message.

Fixes 937
    @nikclayton
    nikclayton committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    32b3b3c View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary elvis

    @nikclayton
    nikclayton committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ed00d4e View commit details
    Browse the repository at this point in the history