Additional Sync script methods #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d methods to merge in additional tkv metadata from outside sources
dmlb2000
reviewed
Jun 24, 2017
| @@ -0,0 +1,36 @@ | |||
| { | |||
| "67": { | |||
| "ncbi_taxonomy_id": 9606, | |||
There was a problem hiding this comment.
I understand what you are trying to do with this now, could you make the key value pairs more generic for the test data set?
dmlb2000
reviewed
Jun 24, 2017
metadata/rest/tkvinfo.py
Outdated
| def __init__(self): | ||
| """Create local objects for subtree items.""" | ||
| self.values_for_key = ValuesForKey() | ||
| self.upload_entries = UploadEntries |
There was a problem hiding this comment.
Having the ability to upload from a url that has the info phrase in it isn't right, we should rename this to be at the root maybe /tkvupload or something
|
This looks good as soon as travis passes I'll merge it |
kauberry
added a commit
to kauberry/pacifica-metadata
that referenced
this pull request
Jul 12, 2017
* master: Additional Sync script methods (pacifica#47) # Conflicts: # metadata/rest/root.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in methods to lookup transactions from a given tkv keyname, and methods to merge in additional tkv metadata from outside sources
Description
Adds classes to handle the lookup and import of transaction key/value data from external repositories for purposes of backfilling extended metadata
Issues Resolved
#46
Check List