Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of npm purls with namespace #93 #106

Merged
merged 5 commits into from
Dec 28, 2022
Merged

Fix parsing of npm purls with namespace #93 #106

merged 5 commits into from
Dec 28, 2022

Conversation

TG1999
Copy link
Collaborator

@TG1999 TG1999 commented Nov 25, 2022

Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com

@TG1999
Fix parsing of npm purls without namespace
702b3a6 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 changed the title Fix parsing of npm purls without namespace Fix parsing of npm purls without namespace #93 Nov 25, 2022
@pombredanne
Copy link
Member

You should update the GH workflows to drop 3.6 and add 3.11

@TG1999
Drop python 3.6 and add 3.11 from CI
b3f79d8 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Fix formatting tests
bf3af8e 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Copy link
Collaborator Author

TG1999 commented Nov 25, 2022

Thanks @pombredanne the CI tests are now running fine.

@TG1999 TG1999 changed the title Fix parsing of npm purls without namespace #93 Fix parsing of npm purls with namespace #93 Nov 28, 2022
pombredanne
pombredanne requested changes Nov 28, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your consideration.

src/packageurl/__init__.py Outdated Show resolved Hide resolved
src/packageurl/__init__.py Outdated Show resolved Hide resolved
src/packageurl/__init__.py Outdated Show resolved Hide resolved
@TG1999
Address review comments
58988f7 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Add CHANGELOG.
c33429e 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Copy link
Collaborator Author

TG1999 commented Nov 28, 2022

We need name to be declared here https://github.com/package-url/packageurl-python/pull/106/files#diff-1ac2b399571df74798b2fbfab357ffa8cce45a332f1e69b6f1ccf86811d44ba6R394 , so we can error out here https://github.com/package-url/packageurl-python/pull/106/files#diff-1ac2b399571df74798b2fbfab357ffa8cce45a332f1e69b6f1ccf86811d44ba6R402

@TG1999 TG1999 mentioned this pull request Dec 26, 2022
Merged
pombredanne
pombredanne approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks

@TG1999 TG1999 merged commit 8639137 into package-url:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TG1999 @pombredanne