Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#202] propose VIP and NIPKG package formats #318

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

samsharp99
Copy link

@samsharp99 samsharp99 commented Aug 7, 2024

-----
``nipkg`` for NI Package format packages:

- The ``namespace`` is the maintainer from the package attributes (optional).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean for the maintainer to be optional? Is it optional because the maintainer has a default?

If it's optional because it doesn't matter, it shouldn't be included because that creates problems for code that needs to match PURLs.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The maintainer is an optional field in the nipkg attributes, so it could be empty. In the pURL spec it should be provided, if present in the nipkg attributes, but otherwise ommitted - hence being optional.

PURL-TYPES.rst Outdated
---
``vip`` for VI Package Manager (VIPM) format packages (LabVIEW):

- The ``namespace`` is the company name from the package attributes (optional).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem like the namespace is used by the native vipm tools (the website makes links like vipm://oglib_numeric), so it probably should not be included here.

Copy link
Author

@samsharp99 samsharp99 Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to remove namespace in commit: c193d21

@jkowalleck jkowalleck linked an issue Oct 17, 2024 that may be closed by this pull request
@johnmhoran johnmhoran added type: nipkg Proposed new type type: vip Proposed new type labels Oct 19, 2024
@jkowalleck jkowalleck changed the title [#202] Add VIP and NIPKG package formats [#202] propose VIP and NIPKG package formats Oct 19, 2024
@samsharp99
Copy link
Author

Clarified nipkg namespace attribute inclusion and removed vip namespace, updated PR from master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Proposed new type type: nipkg Proposed new type type: vip Proposed new type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reserve LabVIEW-related package formats vip / nipkg
4 participants