Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate the core syntax definition from purl type definitions. #79

Closed
wants to merge 1 commit into from
Closed

Separate the core syntax definition from purl type definitions. #79

wants to merge 1 commit into from

Conversation

stevespringett
Copy link
Member

Signed-off-by: stevespringett

@stevespringett stevespringett added this to the 1.0 milestone Apr 2, 2020
iamwillbar
iamwillbar approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@iamwillbar iamwillbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this restructuring, make it less overwhelming at first glance. One minor suggestion inline. Thanks!

README.rst
- Sonatype Lifecycle uses a format id followed by format specific coordinates.
https://help.sonatype.com/display/NXIQ/Component+Details+API+-+v2
- Sonatype Lifecycle uses a format id followed by format specific coordinates.
https://help.sonatype.com/display/NXIQ/Component+Details+API+-+v2


Solution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for the readme I would lead with the solution rather than the problem so people can see at a glance what this is, they can then dig into the context and problem if they want to understand the why.

@stevespringett stevespringett mentioned this pull request Oct 1, 2020
Closed
@pombredanne
Copy link
Member

@stevespringett I am now doing the belated review for this. Thank you ++ for your patience!

@pombredanne pombredanne changed the title Separated the core syntax definition from purl type definitions. Separate the core syntax definition from purl type definitions. Oct 15, 2020
@stevespringett
Copy link
Member Author

Ping. Can we get this merged before any more conflict arise?

@pombredanne
Copy link
Member

@stevespringett Yes! let me do this todat at last and I will handle the merge conflicts.

@stevespringett
Copy link
Member Author

Any chance of getting this merged in?

The CycloneDX spec now has a Cocoapods implementation that contains purl, so I'd like to start defining the cocoapods purl type, but would like to get this merged in first. Otherwise, it just adds to the merge conflicts.

@iamwillbar
Copy link
Member

From a governance perspective what's our policy? Requestor and 1 reviewer? Multiple reviewers? @pombredanne do you want to always get a chance to review before merging?

@pombredanne pombredanne mentioned this pull request May 3, 2021
Merged
@pombredanne
Copy link
Member

Sorry for the late review!
I pushed an alternative PR for your review at #102 that keeps the Git history and line-level blame that we can merge instead.

@pombredanne
Copy link
Member

Closing in favor of #102

@pombredanne pombredanne closed this May 3, 2021
@pombredanne pombredanne deleted the spec-separation branch June 16, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamwillbar iamwillbar iamwillbar approved these changes

@pombredanne pombredanne Awaiting requested review from pombredanne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@stevespringett @pombredanne @iamwillbar