This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
Change server,cli make targets to build for running platform #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #38 +/- ##
=======================================
Coverage 44.51% 44.51%
=======================================
Files 5 5
Lines 620 620
=======================================
Hits 276 276
Misses 334 334
Partials 10 10 ☔ View full report in Codecov by Sentry. |
mmlb
changed the title
|
Thanks @iawells, instead of just the doc update I changed the makefile so it builds for the running platform and thus is more usable. |
|
Actually it looks like the Dockerfile builds the binaries so make is only used for test/dev and having the binaries for the running system is all thats needed. |
`make server` and `make cli` now build for the running platform. Builds for container images occur within the Dockerfile so when building with make its only used for the running platform. Reported-by: Ian Wells <iwells@equinix.com> Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
mmlb
approved these changes
Nov 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cacherc build instructions are misleading and can result in building the wrong thing on ARM macs.