Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if the repo is private only when the pipeline is started #1942

Closed
csomh opened this issue Mar 1, 2023 · 1 comment · Fixed by #2388
Closed

Check if the repo is private only when the pipeline is started #1942

csomh opened this issue Mar 1, 2023 · 1 comment · Fixed by #2388
Labels
area/github Related to GitHub implementation. complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/internal Doesn't affect users directly, may be e.g. infrastructure, DB related.

Comments

@csomh
Copy link
Contributor

csomh commented Mar 1, 2023

In order to reduce the number of GitHub API calls made during a pipeline run, check whether the GitHub repository is private (or enabled for private runs) only once: when the pipeline is created.

See packit/research#171 for more details.
@csomh csomh changed the title Check if the repo is private only when a pipeline is started Check if the repo is private only when the pipeline is started Mar 1, 2023
@csomh csomh mentioned this issue Mar 1, 2023
Merged
@majamassarini majamassarini moved this from new to backlog in Packit Kanban Board Mar 2, 2023
@majamassarini majamassarini mentioned this issue Mar 9, 2023
Open
@lachmanfrantisek lachmanfrantisek added complexity/single-task Regular task, should be done within days. impact/low This issue impacts only a few users. gain/low This doesn't bring that much value to users. kind/internal Doesn't affect users directly, may be e.g. infrastructure, DB related. area/github Related to GitHub implementation. labels Feb 13, 2024
@lachmanfrantisek
Copy link
Member

Still relevant, but not urgent.

lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Apr 2, 2024
@lbarcziova
Skip private repository check for AbstractResultEvent
6d90c12 
Fixes packit#1942
@lbarcziova lbarcziova mentioned this issue Apr 2, 2024
Merged
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Apr 5, 2024
@lbarcziova
Skip private repository check for AbstractResultEvent
49afd8d 
Fixes packit#1942
softwarefactory-project-zuul bot added a commit that referenced this issue Apr 5, 2024
@softwarefactory-project-zuul
Skip private repository check for AbstractResultEvent (#2388)
9cf94d0 
Skip private repository check for AbstractResultEvent

Fixes #1942
RELEASE NOTES BEGIN
N/A
RELEASE NOTES END

Reviewed-by: Maja Massarini
Reviewed-by: František Lachman <flachman@redhat.com>
Reviewed-by: Nikola Forró
Reviewed-by: Laura Barcziová
@github-project-automation github-project-automation bot moved this from backlog to done in Packit Kanban Board Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/github Related to GitHub implementation. complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/internal Doesn't affect users directly, may be e.g. infrastructure, DB related.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip private repository check for AbstractResultEvent lbarcziova/packit-service
2 participants
@csomh @lachmanfrantisek