Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe a plan for downstream part of the workflow #123

Merged
merged 3 commits into from
Apr 11, 2022

Conversation

lachmanfrantisek
Copy link
Member

@lachmanfrantisek lachmanfrantisek commented Oct 21, 2021

preview: https://github.com/lachmanfrantisek/research/blob/downstream/downstream/README.md


TODO:

  • add relevant links
  • cover bugzillas in Bodhi updates
  • create/update separate issues
  • gather feedback from the users

@lachmanfrantisek lachmanfrantisek changed the title Describe a plan for downstream part of the workflow WIP: Describe a plan for downstream part of the workflow Oct 21, 2021
Copy link
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for such a thorough write-up!

downstream/README.md Outdated Show resolved Hide resolved

What can be added is providing a feedback during the process:

- providing a dashboard view for the job
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could link to the Fedora developer dashboard: https://packager-dashboard.fedoraproject.org/

although they provide user-based view and not a package-based view

- I can send a pull-request to a repository containing the list of repositories to build. (The same thing zuul does.)
- I can add a packit config to the distgit repository and configure the job (can be combined with the previous version so we can filter the projects before checking config presence).
- A service authenticated by FAS where I can enable the build and, ideally, configure the process.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure right now if they need to grant packit some extra permissions to be able to create builds and bodhi updates

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since packit FAS user is a packager, maintainers need to add it as a maintainer to the project.

But we can try getting the rights for building all packages, but that would probably require running service in the Fedora infrastructure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, getting proven packager rights wouldn't be trivial to get, I'd say we still need to prove ourself :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can have a "group" or sig to add packager to. F.e. we have @ruby-packagers-sig. That should be enough to have commit bits.

downstream/README.md Outdated Show resolved Hide resolved
downstream/README.md Outdated Show resolved Hide resolved
downstream/README.md Outdated Show resolved Hide resolved
@jkonecny12
Copy link

After a quick read through it seems like a nice list. Thanks

@lachmanfrantisek lachmanfrantisek force-pushed the downstream branch 2 times, most recently from be1a8cb to 7d5ed98 Compare November 10, 2021 15:51
lachmanfrantisek added a commit to lachmanfrantisek/packit that referenced this pull request Nov 11, 2021
This is the easiest solution how to do this.
See packit/research#123 for more information.

Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@ochosi
Copy link

ochosi commented Nov 11, 2021

Looks good! As we're already doing this workflow in an automated fashion and I can find all the steps we're currently doing in your description I'm confident to say that your covering our use case :)

lachmanfrantisek added a commit to lachmanfrantisek/packit that referenced this pull request Nov 22, 2021
This is the easiest solution how to do this.
See packit/research#123 for more information.

Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@lachmanfrantisek lachmanfrantisek force-pushed the downstream branch 3 times, most recently from 8b499ad to 5eacf86 Compare November 24, 2021 10:11
softwarefactory-project-zuul bot added a commit to packit/packit that referenced this pull request Nov 24, 2021
…nstream-koji-build

Add downstream Koji build as new type

This is the easiest solution how to do this.
See packit/research#123 for more information.
Related to packit/packit-service#55
Merge before TBD


N/A (will be mentioned in service)

Reviewed-by: Tomas Tomecek <tomas@tomecek.net>
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
Signed-off-by: Frantisek Lachman <flachman@redhat.com>
Upstream issue: pallets/click#2232

Signed-off-by: Frantisek Lachman <flachman@redhat.com>
@lachmanfrantisek lachmanfrantisek changed the title WIP: Describe a plan for downstream part of the workflow Describe a plan for downstream part of the workflow Apr 11, 2022
@lachmanfrantisek lachmanfrantisek marked this pull request as ready for review April 11, 2022 13:23
@lachmanfrantisek
Copy link
Member Author

Hi all,

thanks for all the feedback. I've tried to update the text to match the current state and mark what we've implemented in the meantime.

@lachmanfrantisek lachmanfrantisek merged commit 09e4a40 into packit:main Apr 11, 2022
@lachmanfrantisek lachmanfrantisek deleted the downstream branch April 11, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants