fix: infinite loop theme flicker (#329)

pacocoursey · Dec 5, 2024 · ae2ab9b · ae2ab9b
1 parent 32ef714
commit ae2ab9b
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/next-themes/src/index.tsx b/next-themes/src/index.tsx
@@ -125,8 +125,11 @@ const Theme = ({
       }
 
       // If default theme set, use it if localstorage === null (happens on local storage manual deletion)
-      const theme = e.newValue || defaultTheme
-      setTheme(theme)
+      if (!e.newValue) {
+        setTheme(defaultTheme)
+      } else {
+        setThemeState(e.newValue) // Direct state update to avoid loops
+      }
     }
 
     window.addEventListener('storage', handleStorage)