Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to pnpm monorepo, fix Vercel builds, improve test caching, lint #202

Merged
merged 18 commits into from
Aug 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 31 additions & 6 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,37 @@ jobs:
timeout-minutes: 5
runs-on: ubuntu-latest
steps:
- name: Prepare Playwright
uses: actions/checkout@v2
- uses: actions/checkout@v3

- uses: pnpm/action-setup@v2
with:
version: 8

- uses: actions/setup-node@v2
with:
node-version: "18"
- run: yarn
- run: npx playwright install --with-deps
node-version: 18.x
cache: 'pnpm'

- run: pnpm install
env:
CI: true

- name: Store Playwright's Version
run: |
PLAYWRIGHT_VERSION=$(pnpm ls @playwright/test | grep @playwright | sed 's/.*@//')
echo "Playwright's Version: $PLAYWRIGHT_VERSION"
echo "PLAYWRIGHT_VERSION=$PLAYWRIGHT_VERSION" >> $GITHUB_ENV

- name: Cache Playwright Browsers for Playwright's Version
id: cache-playwright-browsers
uses: actions/cache@v3
with:
path: ~/.cache/ms-playwright
key: playwright-browsers-${{ env.PLAYWRIGHT_VERSION }}

- name: Setup Playwright
if: steps.cache-playwright-browsers.outputs.cache-hit != 'true'
run: npx playwright install --with-deps

- name: Run tests
run: yarn test:e2e
run: pnpm test:e2e
24 changes: 9 additions & 15 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,29 +4,23 @@ on: push

jobs:
test:
name: Run Unit Tests
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Get yarn cache
id: yarn-cache
run: echo "::set-output name=dir::$(yarn cache dir)"

- uses: actions/cache@v1
- uses: pnpm/action-setup@v2
with:
path: ${{ steps.yarn-cache.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-
version: 8

- uses: actions/setup-node@v2
- uses: actions/setup-node@v3
with:
node-version: 18.x
cache: 'pnpm'

- name: yarn install
run: yarn
- run: pnpm install
env:
CI: true

- name: Run test
run: yarn test
- name: Run tests
run: pnpm test
1 change: 0 additions & 1 deletion .nvmrc

This file was deleted.

3 changes: 3 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.next
dist
build
12 changes: 6 additions & 6 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"semi": false,
"singleQuote": true,
"trailingComma": "none",
"arrowParens": "avoid",
"printWidth": 100
}
"semi": false,
"singleQuote": true,
"trailingComma": "none",
"arrowParens": "avoid",
"printWidth": 100
}
23 changes: 0 additions & 23 deletions e2e/forced-theme.test.ts

This file was deleted.

44 changes: 0 additions & 44 deletions e2e/switch-theme.test.ts

This file was deleted.

29 changes: 0 additions & 29 deletions e2e/system-theme.test.ts

This file was deleted.

36 changes: 0 additions & 36 deletions e2e/util.ts

This file was deleted.

12 changes: 5 additions & 7 deletions examples/example/package.json
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
{
"name": "example",
"version": "1.0.0",
"main": "index.js",
"license": "MIT",
"scripts": {
"dev": "next",
"build": "next build",
"start": "next start"
},
"dependencies": {
"next": "^12.1.6",
"next-themes": "*",
"react": "^18.1.0",
"react-dom": "^18.1.0"
"next": "12.2.2",
"next-themes": "workspace:*",
"react": "18.2.0",
"react-dom": "18.2.0"
}
}
}
2 changes: 1 addition & 1 deletion examples/example/pages/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const Index = () => {
return (
<div>
<h1>next-themes Example</h1>
<select value={theme} onChange={e => setTheme(e.target.value)} data-test-id='theme-selector'>
<select value={theme} onChange={e => setTheme(e.target.value)} data-test-id="theme-selector">
<option value="system">System</option>
{mounted && (
<>
Expand Down
4 changes: 2 additions & 2 deletions examples/example/styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ body {

body {
min-height: 100vh;
font-family: -apple-system, BlinkMacSystemFont, Segoe UI, Roboto, Oxygen,
Ubuntu, Cantarell, Fira Sans, Droid Sans, Helvetica Neue, sans-serif;
font-family: -apple-system, BlinkMacSystemFont, Segoe UI, Roboto, Oxygen, Ubuntu, Cantarell,
Fira Sans, Droid Sans, Helvetica Neue, sans-serif;
background: var(--bg);
color: var(--fg);
display: flex;
Expand Down
21 changes: 10 additions & 11 deletions examples/tailwind/package.json
Original file line number Diff line number Diff line change
@@ -1,21 +1,20 @@
{
"name": "with-tailwindcss",
"name": "tailwind",
"version": "1.0.0",
"scripts": {
"dev": "next",
"build": "next build",
"start": "next start"
},
"dependencies": {
"next": "^12.1.6",
"next-themes": "*",
"react": "^18.1.0",
"react-dom": "^18.1.0"
"next": "12.2.2",
"next-themes": "workspace:*",
"react": "18.2.0",
"react-dom": "18.2.0"
},
"devDependencies": {
"autoprefixer": "^10.0.2",
"postcss": "^8.1.7",
"tailwindcss": "^2.0.1"
},
"license": "MIT"
}
"autoprefixer": "10.4.15",
"postcss": "8.4.28",
"tailwindcss": "3.3.3"
}
}
2 changes: 1 addition & 1 deletion examples/tailwind/pages/_app.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import '../styles.css'

function MyApp({ Component, pageProps }) {
return (
<ThemeProvider forcedTheme={Component.theme || undefined} attribute='class'>
<ThemeProvider forcedTheme={Component.theme || undefined} attribute="class">
<Component {...pageProps} />
</ThemeProvider>
)
Expand Down
2 changes: 1 addition & 1 deletion examples/tailwind/tailwind.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ module.exports = {
removeDeprecatedGapUtilities: true,
purgeLayersByDefault: true
},
purge: ['./components/**/*.{js,ts,jsx,tsx}', './pages/**/*.{js,ts,jsx,tsx}'],
content: ['./components/**/*.{js,ts,jsx,tsx}', './pages/**/*.{js,ts,jsx,tsx}'],
darkMode: 'class'
}
2 changes: 1 addition & 1 deletion license.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
SOFTWARE.
25 changes: 12 additions & 13 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,27 +1,26 @@
{
"name": "next-themes",
"private": true,
"version": "0.2.0",
"workspaces": [
"packages/*",
"examples/*"
],
"scripts": {
"prepublish": "yarn build --filter=next-themes",
"prepublish": "pnpm build --filter=next-themes",
"build": "turbo build",
"start": "turbo start",
"dev": "turbo dev",
"test": "turbo test",
"test:e2e": "yarn playwright test"
"test:e2e": "pnpm playwright test",
"lint": "prettier . --write"
},
"dependencies": {},
"devDependencies": {
"@playwright/test": "^1.21.1",
"@playwright/test": "^1.37.1",
"prettier": "^2.2.1",
"turbo": "^1.10.9"
"turbo": "^1.10.12"
},
"repository": {
"type": "git",
"url": "https://github.com/pacocoursey/next-themes.git"
}
}
},
"engines": {
"node": ">=18",
"pnpm": ">=8"
},
"packageManager": "pnpm@8.6.3"
}
4 changes: 2 additions & 2 deletions packages/next-themes/jest.config.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module.exports = {
testRegex: '(/__tests__/.*|(\\.|/)(test|spec))\\.(jsx?|tsx?)$',
}
testRegex: '(/__tests__/.*|(\\.|/)(test|spec))\\.(jsx?|tsx?)$'
}
Loading