Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add react v19 to peer deps #315

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

Yonom
Copy link
Contributor

@Yonom Yonom commented Oct 22, 2024

Thanks a lot for this package

I get the following warning from pnpm after upgrading to NextJS v15 (released today), which installs react 19 RC

React 19 is technically still in RC stage, but since a stable version of a major Metaframework is installing it, it's a sign that it's ready for production use and will now be used by many projects.

 └─┬ next-themes 0.3.0
   ├──  unmet peer react@"^16.8 || ^17 || ^18": found 19.0.0-rc-65a56d0e-20241020
   └──  unmet peer react-dom@"^16.8 || ^17 || ^18": found 19.0.0-rc-65a56d0e-20241020

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-themes-basic ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 0:52am
next-themes-tailwind ❌ Failed (Inspect) Oct 22, 2024 0:52am
next-themes-with-app-dir ❌ Failed (Inspect) Oct 22, 2024 0:52am

@bannednull
Copy link

image
It worked for me like this

@pacocoursey pacocoursey merged commit ad4daf2 into pacocoursey:main Nov 4, 2024
4 of 6 checks passed
@Yonom Yonom deleted the react-19 branch November 4, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants