Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: map theme to class using ValueObject in injected script #330

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

danielgavrilov
Copy link
Contributor

I think this is a bug: the CSS classes are being correctly remapped in order to remove them all, but the class being added is not mapped using the ValueObject:

const classes = isClass && value ? themes.map(t => value[t] || t) : themes
if (isClass) {
el.classList.remove(...classes)
el.classList.add(theme)

@pacocoursey pacocoursey merged commit 1b51044 into pacocoursey:main Dec 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants