Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add brave-browser-deb #293

Merged
merged 3 commits into from
Sep 19, 2021
Merged

add brave-browser-deb #293

merged 3 commits into from
Sep 19, 2021

Conversation

Zahrun
Copy link
Contributor

@Zahrun Zahrun commented Sep 16, 2021

and cleaned commit history

D-Brox
D-Brox requested changes Sep 16, 2021
View reviewed changes
Copy link
Member

@D-Brox D-Brox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add packages to packagelist

@Zahrun Zahrun requested a review from D-Brox September 16, 2021 21:25
wizard-28
wizard-28 reviewed Sep 17, 2021
View reviewed changes
Copy link
Member

@wizard-28 wizard-28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain again why this release edition needs a separate key ring whereas the beta and nightly don't need one?

@Zahrun
Copy link
Contributor Author

Zahrun commented Sep 17, 2021 •
edited
Loading

Can you explain again why this release edition needs a separate key ring whereas the beta and nightly don't need one?

It is there in the official deb dependency list for the release version only, "to ensure that our package/repo signing key is up-to-date" (see Brave Issue 4205).

@wizard-28
Copy link
Member

Well, this happened:

[+] INFO: Installing brave-keyring-deb
[*] WARNING: Prompts are disabled
[*] WARNING: There is no package with the name brave-keyring-deb

@Elsie19
Copy link
Member

Elsie19 commented Sep 19, 2021

Did you add his repo?

@wizard-28
Copy link
Member

Did you add his repo?

Oh... Yeah it should work on merge... My bad.

@wizard-28 wizard-28 merged commit b1875de into pacstall:master Sep 19, 2021
@Elsie19
Copy link
Member

Elsie19 commented Sep 19, 2021

Did you add his repo?

Oh... Yeah it should work on merge... My bad.

Or you could have just used the -A flag...

@wizard-28
Copy link
Member

Did you add his repo?

Oh... Yeah it should work on merge... My bad.

Or you could have just used the -A flag...

I couldn't have tested it anyways... No space left on device.

Zahrun added a commit to Zahrun/pacstall-programs that referenced this pull request Oct 17, 2021
@Zahrun @wizard-28
add brave-browser-deb (pacstall#293)
b9887e0 
* add brave-browser-deb

* add packages to packagelist

Co-authored-by: Zahrun <Zahrun@github.com>
Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com>
D-Brox pushed a commit that referenced this pull request Oct 26, 2021
@Zahrun @wizard-28
add brave-browser-deb (#293)
12cde54 
* add brave-browser-deb

* add packages to packagelist

Co-authored-by: Zahrun <Zahrun@github.com>
Co-authored-by: Sourajyoti Basak <wiz28@protonmail.com>
Former-commit-id: b1875de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D-Brox D-Brox D-Brox approved these changes

@Elsie19 Elsie19 Elsie19 approved these changes

@wizard-28 wizard-28 wizard-28 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zahrun @wizard-28 @Elsie19 @D-Brox