Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding azure files for app service deployment #349

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thekrayze
Copy link

Added Bicep file and paramete
added readme
added az cli commands

@YOU54F
Copy link
Member

YOU54F commented Sep 27, 2024

Hey thanks for this.

I think it would be better added to the pact-broker-docker repo, similar to this pull request

https://github.com/pact-foundation/pact-broker-docker/pull/176/files

with the files in an examples subfolder such as example-azure-deployment

https://github.com/pact-foundation/pact-broker-docker/tree/master/example-k8s-deployment

The updated docs will be pulled into this website

https://docs.pact.io/pact_broker/docker_images/pactfoundation#running-on-aws-with-an-alb

@YOU54F YOU54F self-requested a review September 27, 2024 12:45
Copy link
Member

@YOU54F YOU54F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assets should be moved to https://github.com/pact-foundation/pact-broker-docker along with instructions, that will be pulled into the website via a sync job. 👍🏾

Thanks for the addition however

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants