Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow for configuring of revisionHistoryLimit #25

Conversation

knechtionscoding
Copy link
Contributor

@knechtionscoding knechtionscoding commented Jan 20, 2023

Closes #24

Chose to put it in an if clause to prevent unintended side effects; while allowing those who want to to set the value properly.

@ChrisJBurns
Copy link
Contributor

Have you run the pre-commit config? In order to generate the Helm docs for the additional value fields?

docs: generate readme values
@knechtionscoding
Copy link
Contributor Author

Have you run the pre-commit config? In order to generate the Helm docs for the additional value fields?

Done!

# -- Number of Pact Broker replicas to deploy
replicaCount: 1
# -- (int) Number of Pact Broker replicas to deploy
replicaCount:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not should why we are removing the default value here of 1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo, apologies, was going fast last night

@ChrisJBurns
Copy link
Contributor

@knechtionscoding I think the version just needs a bump. As this is a backwards compatible feature, it will be a minor, so 0.5.0 👍

I'll be putting up a contributing guide as well just so folks are aware of what they need to change. Just do a search for 0.4.2 and replace with 0.5.0. I think you've done it for the README badges, but the main Chart.yaml will need it also.

@ChrisJBurns
Copy link
Contributor

ChrisJBurns commented Jan 21, 2023

@knechtionscoding Thanks for this. I'm going to get #29 in first, I can then use this PR in order to test the new release note generation that PR#29 implements. So merge master back into your branch and we can get this in 👍

@knechtionscoding
Copy link
Contributor Author

@ChrisJBurns merged trunk back; should be ready to go for you.

@ChrisJBurns ChrisJBurns merged commit e4b31e8 into pact-foundation:master Jan 21, 2023
@knechtionscoding knechtionscoding deleted the feat/configure-revision-history-limit branch February 7, 2023 14:57
roulettedares pushed a commit to roulettedares/pact-broker-chart that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RevisionHistoryLimit should be configurable
2 participants