-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow for configuring of revisionHistoryLimit #25
feat: allow for configuring of revisionHistoryLimit #25
Conversation
Have you run the pre-commit config? In order to generate the Helm docs for the additional value fields? |
docs: generate readme values
Done! |
charts/pact-broker/values.yaml
Outdated
# -- Number of Pact Broker replicas to deploy | ||
replicaCount: 1 | ||
# -- (int) Number of Pact Broker replicas to deploy | ||
replicaCount: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not should why we are removing the default value here of 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo, apologies, was going fast last night
@knechtionscoding I think the version just needs a bump. As this is a backwards compatible feature, it will be a minor, so I'll be putting up a contributing guide as well just so folks are aware of what they need to change. Just do a search for |
@knechtionscoding Thanks for this. I'm going to get #29 in first, I can then use this PR in order to test the new release note generation that PR#29 implements. So merge |
@ChrisJBurns merged trunk back; should be ready to go for you. |
- bumps pact broker app version
Closes #24
Chose to put it in an if clause to prevent unintended side effects; while allowing those who want to to set the value properly.