feat: support imagePullSecrets on the service account as well as the deployment #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisJBurns
reviewed
Jan 21, 2023
docs: generate readme
ChrisJBurns
reviewed
Jan 21, 2023
|
@knechtionscoding will need to rebase with master, make sure to follow the steps outlined in the new contributing docs as well just so we avoid any future issues as we've run into a few issues with bad kubernetes manifests being created from the charts - this was mainly by not running |
|
@ChrisJBurns Sorry, just got back to this. I've updated the chart to template properly, and followed the new contributing documentation. |
ChrisJBurns
requested changes
Feb 2, 2023
ChrisJBurns
approved these changes
Feb 3, 2023
roulettedares
pushed a commit
to roulettedares/pact-broker-chart
that referenced
this pull request
Mar 13, 2023
…deployment (pact-foundation#28) * feat: support imagePullSecrets on the service account as well as the deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27