enabled poddisruptionbudget in case more than one broker instance is used

[sherifkayad]

enabled poddisruptionbudget in case more than one broker instance is used

[sherifkayad]

I will have a look at the linting tomorrow morning first thing. It might have to do with my VSCode

[sherifkayad]

@ChrisJBurns can you please have another look?

[ChrisJBurns]

@sherifkayad Would you be able to bump the minor version as it's a new feature, I can approve and run the workflow once this is done 👍

[sherifkayad]

@ChrisJBurns done! thanks for the feedback.

[sherifkayad]

@ChrisJBurns can you help me identify why the linting is failing?

[sherifkayad]

locally helm lint is succeeding

[ChrisJBurns]

@sherifkayad I believe it's trailing whitespaces:

charts/pact-broker/values.yaml
  Error: 348:1 [trailing-spaces] trailing spaces

[sherifkayad]

Can we re-check now?

[sherifkayad]

@ChrisJBurns seems to be passing after my latest push 😅

[ChrisJBurns]

lgtm

[ChrisJBurns]

@sherifkayad One last thing, I've only just noticed, would you be able to sign your commit? The merging is blocked until this happens. The code changes are perfect, we just need to sign the commits

[sherifkayad]

can you check now? again did a sign-off and forced pushing

[ChrisJBurns]

@sherifkayad Sign-off is a great addition, but I was referring to commit signing. Apologies for being a pain, but it does add a layer of security to the commits.

[sherifkayad]

@ChrisJBurns also done ;) there you go

[ChrisJBurns]

@sherifkayad Thanks again! All merged :)

[sherifkayad]

Sure thing! Thanks for your time reviewing as well.