Skip to content

Commit 2acf846

Browse files
committed
fix(message): set correct default for message Pact write mode. Fixes #96
1 parent 6b222e8 commit 2acf846

File tree

4 files changed

+14
-25
lines changed

4 files changed

+14
-25
lines changed

dsl/pact.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -532,11 +532,10 @@ func (p *Pact) VerifyMessageConsumerRaw(message *Message, handler MessageConsume
532532

533533
// If no errors, update Message Pact
534534
return p.pactClient.UpdateMessagePact(types.PactMessageRequest{
535-
Message: message,
536-
Consumer: p.Consumer,
537-
Provider: p.Provider,
538-
PactFileWriteMode: p.PactFileWriteMode,
539-
PactDir: p.PactDir,
535+
Message: message,
536+
Consumer: p.Consumer,
537+
Provider: p.Provider,
538+
PactDir: p.PactDir,
540539
})
541540
}
542541

examples/messages/consumer/message_pact_consumer_test.go

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -107,11 +107,10 @@ var logDir = fmt.Sprintf("%s/log", dir)
107107
// Setup the Pact client.
108108
func createPact() dsl.Pact {
109109
return dsl.Pact{
110-
Consumer: "PactGoMessageConsumer",
111-
Provider: "PactGoMessageProvider",
112-
LogDir: logDir,
113-
PactDir: pactDir,
114-
LogLevel: "DEBUG",
115-
PactFileWriteMode: "update",
110+
Consumer: "PactGoMessageConsumer",
111+
Provider: "PactGoMessageProvider",
112+
LogDir: logDir,
113+
PactDir: pactDir,
114+
LogLevel: "DEBUG",
116115
}
117116
}

examples/messages/provider/message_pact_provider_test.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,9 @@ var logDir = fmt.Sprintf("%s/log", dir)
7171
// Setup the Pact client.
7272
func createPact() dsl.Pact {
7373
return dsl.Pact{
74-
Consumer: "PactGoMessageConsumer",
75-
Provider: "PactGoMessageProvider",
76-
LogDir: logDir,
77-
LogLevel: "DEBUG",
78-
PactFileWriteMode: "update",
74+
Consumer: "PactGoMessageConsumer",
75+
Provider: "PactGoMessageProvider",
76+
LogDir: logDir,
77+
LogLevel: "DEBUG",
7978
}
8079
}

types/pact_message_request.go

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,6 @@ type PactMessageRequest struct {
1818
// PactDir is the location of where pacts should be stored
1919
PactDir string
2020

21-
// PactFileWriteMode specifies how to write to the Pact file, for the life
22-
// of a Mock Service.
23-
// "overwrite" will always truncate and replace the pact after each run
24-
// "update" will append to the pact file, which is useful if your tests
25-
// are split over multiple files and instantiations of a Mock Server
26-
// See https://github.com/pact-foundation/pact-ruby/blob/master/documentation/configuration.md#pactfile_write_mode
27-
PactFileWriteMode string
28-
2921
// Args are the arguments sent to to the message service
3022
Args []string
3123
}
@@ -41,7 +33,7 @@ func (m *PactMessageRequest) Validate() error {
4133
}
4234

4335
m.Args = append(m.Args, []string{
44-
m.PactFileWriteMode,
36+
"update",
4537
string(body),
4638
"--consumer",
4739
m.Consumer,

0 commit comments

Comments
 (0)