Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.3 Build fails #121

Closed
taboularasa opened this issue Oct 31, 2019 · 2 comments
Closed

v1.0.3 Build fails #121

taboularasa opened this issue Oct 31, 2019 · 2 comments

Comments

@taboularasa
Copy link
Contributor

Software versions

  • OS: e.g. Mac OSX 10.14.6
  • Consumer Pact library: e.g. Pact go v1.0.3
  • Golang Version: go1.12.7 darwin/amd64

Expected behaviour

successful build

Actual behaviour

failed to build

94da099#diff-2a840891922e12f5e3573f1d11373d6eR64 includes a reference to the os package but does not include the import statement.

Steps to reproduce

build package

Relevent log files

github.com/pact-foundation/pact-go/dsl/publish.go:64:14: undefined: os

@mefellows
Copy link
Member

OK so there was a check for an exit code of 1 during in our test.sh script - but the test was failing with exit code 2! I've fixed this, and confirmed that a broken test (which in this case we had) would fail the build.

1.0.4 out the door.

@taboularasa
Copy link
Contributor Author

taboularasa commented Nov 1, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants